clintropolis opened a new pull request #11352:
URL: https://github.com/apache/druid/pull/11352
### Description
Makes #11331 more true by making SQL queries ignore `bySegment` in the query
context, which is incompatible with the SQL result format (and probably SQL in
general) and will cause an explosion when it tries to convert the response
format.
Also added a test for `SqlLifecycle` state transitions while I was here, to
cover the happy path and make sure state transitions happen as expected. This
stuff was all pretty well indirectly tested, but didn't have an actual test of
its own.
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
