gianm commented on a change in pull request #11358:
URL: https://github.com/apache/druid/pull/11358#discussion_r650183342
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java
##########
@@ -360,4 +364,25 @@ public static VectorValueSelector makeVectorValueSelector(
}
return columnSelectorFactory.makeValueSelector(fieldName);
}
+
+ public static Supplier<byte[]> getSimpleAggregatorCacheKeySupplier(
Review comment:
Nice.
##########
File path: core/src/main/java/org/apache/druid/math/expr/Exprs.java
##########
@@ -29,6 +29,9 @@
public class Exprs
{
+ public static final byte EXPR_CACHE_KEY = 0x00;
+ public static final byte LOOKUP_EXPR_KEY = 0x01;
Review comment:
Naming? LOOKUP_EXPR_KEY should be something like LOOKUP_CACHE_KEY, I
think. For symmetry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
