xvrl commented on a change in pull request #11363:
URL: https://github.com/apache/druid/pull/11363#discussion_r652149196
##########
File path: pom.xml
##########
@@ -1777,75 +1778,101 @@
</plugin>
</plugins>
</build>
- </profile>
- <profile>
+ </profile>
+ <profile>
<id>strict</id>
+ <activation>
+ <property>
+ <name>strictCompile</name>
+ </property>
+ </activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <compilerId>javac-with-errorprone</compilerId>
- <forceJavacCompilerUse>true</forceJavacCompilerUse>
<fork>true</fork>
<meminitial>1024m</meminitial>
<maxmem>3000m</maxmem>
<source>${maven.compiler.source}</source>
<target>${maven.compiler.target}</target>
<showWarnings>false</showWarnings>
<compilerArgs>
- <arg>-XepDisableWarningsInGeneratedCode</arg>
-
- <arg>-Xep:ClassCanBeStatic:ERROR</arg>
-
<arg>-Xep:PreconditionsInvalidPlaceholder:ERROR</arg>
- <arg>-Xep:MissingOverride:ERROR</arg>
- <arg>-Xep:DefaultCharset:ERROR</arg>
-
<arg>-Xep:QualifierOrScopeOnInjectMethod:ERROR</arg>
-
-
<arg>-Xep:AssistedInjectAndInjectOnSameConstructor</arg>
- <arg>-Xep:AutoFactoryAtInject</arg>
- <arg>-Xep:ClassName</arg>
- <arg>-Xep:ComparisonContractViolated</arg>
- <arg>-Xep:DepAnn</arg>
- <arg>-Xep:DivZero</arg>
- <arg>-Xep:EmptyIf</arg>
-
<arg>-Xep:InjectInvalidTargetingOnScopingAnnotation</arg>
- <arg>-Xep:InjectMoreThanOneQualifier</arg>
-
<arg>-Xep:InjectScopeAnnotationOnInterfaceOrAbstractClass</arg>
-
<arg>-Xep:InjectScopeOrQualifierAnnotationRetention</arg>
- <arg>-Xep:InjectedConstructorAnnotations</arg>
- <arg>-Xep:InsecureCryptoUsage</arg>
-
<arg>-Xep:JMockTestWithoutRunWithOrRuleAnnotation</arg>
- <arg>-Xep:JavaxInjectOnFinalField</arg>
- <arg>-Xep:LockMethodChecker</arg>
- <arg>-Xep:LongLiteralLowerCaseSuffix</arg>
- <arg>-Xep:NoAllocation</arg>
- <arg>-Xep:NonRuntimeAnnotation</arg>
- <arg>-Xep:NumericEquality</arg>
- <arg>-Xep:ParameterPackage</arg>
-
<arg>-Xep:ProtoStringFieldReferenceEquality</arg>
- <arg>-Xep:UnlockMethod</arg>
- </compilerArgs>
+ <arg>-XDcompilePolicy=simple</arg>
+ <!-- disable LongFloatConversion until
https://github.com/google/error-prone/issues/2396 is fixed -->
+ <arg>-Xplugin:ErrorProne
-XepExcludedPaths:.*/target/generated-(test-)?sources/.*
-XepDisableWarningsInGeneratedCode -Xep:ClassCanBeStatic:ERROR
-Xep:PreconditionsInvalidPlaceholder:ERROR -Xep:MissingOverride:ERROR
-Xep:DefaultCharset:ERROR -Xep:QualifierOrScopeOnInjectMethod:ERROR
-Xep:AssistedInjectAndInjectOnSameConstructor -Xep:AutoFactoryAtInject
-Xep:ClassName -Xep:ComparisonContractViolated -Xep:DepAnn -Xep:DivZero
-Xep:EmptyIf -Xep:InjectInvalidTargetingOnScopingAnnotation
-Xep:InjectMoreThanOneQualifier
-Xep:InjectScopeAnnotationOnInterfaceOrAbstractClass
-Xep:InjectScopeOrQualifierAnnotationRetention
-Xep:InjectedConstructorAnnotations -Xep:InsecureCryptoUsage
-Xep:JMockTestWithoutRunWithOrRuleAnnotation -Xep:JavaxInjectOnFinalField
-Xep:LockMethodChecker -Xep:LongLiteralLowerCaseSuffix -Xep:NoAllocation
-Xep:NonRuntimeAnnotation -Xep:NumericEquality
-Xep:ProtoStringFieldReferenceEquality -Xep:UnlockMethod
-Xep:LongFloatConversion:OFF</arg>
Review comment:
unfortunately we cannot wrap arguments in JDK 8, it's only possible for
JDK 9 and beyond see https://errorprone.info/docs/flags#maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
