clintropolis commented on a change in pull request #11374:
URL: https://github.com/apache/druid/pull/11374#discussion_r656048289
##########
File path: docs/development/extensions-core/kafka-ingestion.md
##########
@@ -268,7 +268,7 @@ For such consumer properties, user can implement a
[DynamicConfigProvider](../..
`druid.dynamic.config.provider`=`{"type":
"<registered_dynamic_config_provider_name>", ...}`
in consumerProperties map.
-Note: In 0.20.0 or older Druid versions, for SSL connections, the `keystore`,
`truststore` and `key` passwords can also be provided as a [Password
Provider](../../operations/password-provider.md). This is deprecated.
+Note: In 0.21.1 or older Druid versions, for SSL connections, the `keystore`,
`truststore` and `key` passwords can also be provided as a [Password
Provider](../../operations/password-provider.md). This is deprecated.
Review comment:
Since I'm not sure if/when `PasswordProvider` will be removed, its
probably more future proof to reword this section something like:
```suggestion
Note: SSL connections may also be supplied using the deprecated [Password
Provider](../../operations/password-provider.md) interface to define the
`keystore`, `truststore`, and `key`. This functionality might be removed in a
future release.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
