jihoonson commented on a change in pull request #11294:
URL: https://github.com/apache/druid/pull/11294#discussion_r658301515
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/Appenderators.java
##########
@@ -108,7 +108,28 @@ public static Appenderator createOffline(
boolean batchMemoryMappedIndex
)
{
- return new AppenderatorImpl(
+ if (batchMemoryMappedIndex) {
+ // fallback to code know to be working, this is just a fallback option
in case new
+ // batch appenderator has some early bugs but we will remove this
fallback as soon as
+ // we determine that batch appenderator code is stable
Review comment:
How can we determine that the new code is stable? Is there anything you
are imagining what kind of testings we must do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
