loquisgon commented on a change in pull request #11294:
URL: https://github.com/apache/druid/pull/11294#discussion_r658472584
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/Appenderators.java
##########
@@ -108,7 +108,28 @@ public static Appenderator createOffline(
boolean batchMemoryMappedIndex
)
{
- return new AppenderatorImpl(
+ if (batchMemoryMappedIndex) {
Review comment:
Unless we do a formal proof for correctness of a piece of code one can
never be sure that code is bug free but this is not practical for this code. We
have done the due diligence for this code: unit tests, integration tests,
performance tests, soak/stress tests. Since the changes are deep and this area
of code is critical for batch ingestion, out of an abundance of caution, I
still suggest having a fall back flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
