bananaaggle commented on a change in pull request #11362:
URL: https://github.com/apache/druid/pull/11362#discussion_r659123755
##########
File path:
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/SchemaRegistryBasedAvroBytesDecoder.java
##########
@@ -91,17 +98,62 @@ public int getCapacity()
}
@JsonProperty
- public Map<String, ?> getConfig()
+ public Map<String, Object> getConfig()
{
return config;
}
@JsonProperty
- public Map<String, String> getHeaders()
+ public Map<String, Object> getHeaders()
{
return headers;
}
+ protected Map<String, String> createRegistryHeader()
Review comment:
I will add unit tests for it. As for Kafka, In
[#11372](https://github.com/apache/druid/pull/11372), I add
DynamicConfigProvider for Kafka in producer properties. I think I can do the
changes for Kafka in this [#11372](https://github.com/apache/druid/pull/11372),
do you think it is suitable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
