bananaaggle edited a comment on issue #9351:
URL: https://github.com/apache/druid/issues/9351#issuecomment-869606712
> I still think we should deprecate `PasswordProvider`. If your concern is
that users now have to set a map instead of a simple string in their config, I
think it's more about how we construct `DynamicConfigProvider` from the user
configuration rather than using `DynamicConfigProvider`. For example, we can
provide user configurations like below
>
> * `druid.metadata.storage.connector.credentials.type = mapString`
> * `druid.metadata.storage.connector.credentials.user = druid`
> * `druid.metadata.storage.connector.credentials.password = mypassword`
>
> , but construct a `MapStringDynamicConfigProvider` from these configs that
has a map of `{ "user": "druid", "password": "mypassword" }`.
Hi @jihoonson! I make some attempts to adapt some classes to
DynamicConfigProvider in [#11389](https://github.com/apache/druid/pull/11389).
I think we can provide DynamicConfigProvider for users in config, and users
should know which key needed in a map. For example, if users want to add `user
` by dynamicConfigProvider, they should add config like this:
```
druid.metadata.storage.connector.dynamicConfigProvider =
{
"type": "environment",
"variables":
{
"user": "MY_USER_NAME_VAR"
}
}
```
When we deprecate `PasswordProvider`, we should change field which is in
type of `PasswordProvider` to `String`, then users can continue using plaintext
in their config. Do you think it's a proper design? I'll add unit test and
document for this PR when we finishing planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
