yuanlihan commented on a change in pull request #11257:
URL: https://github.com/apache/druid/pull/11257#discussion_r663620645
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/ReservoirSegmentSampler.java
##########
@@ -31,6 +32,42 @@
private static final EmittingLogger log = new
EmittingLogger(ReservoirSegmentSampler.class);
+ static List<BalancerSegmentHolder> getRandomBalancerSegmentHolders(
+ final List<ServerHolder> serverHolders,
+ Set<String> broadcastDatasources,
+ int k
Review comment:
It makes sense to me to retain the `percentOfSegmentsToConsider` and add
an another dynamic parameter `useBatchedSegmentSampler` to enable the new
improvement. In this way, the changing will be less aggressive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
