maytasm opened a new pull request #11426:
URL: https://github.com/apache/druid/pull/11426
compaction/status API retains status for datasources that no longer existed
causing in-memory used to grow unbounded
### Description
The compaction/status API retains stats of datasources that were previously
compacted in memory. The purpose of this is to be able to maintain and report
compaction status of datasource (how much of it was compacted, how much left to
compacted, etc.) even after compaction was disabled (compaction config was
deleted). The bug here is that the compaction/status API retains stats of
datasources that was deleted too. This can causes the in-bound memory used to
grow unbound.
This change removes any datasource that does not have an enabled auto
compaction config from the compaction/status API. This means that the
compaction/status API will now only return datasource that has auto compaction
config enabled in the latest auto compaction run only. The reason for removing
stats for datasource that is active but has auto compaction disabled is that
the latest stats will no longer be accurate and instead can be misleading as
that datasource's shape changes (more data ingested, new intervals, etc.)
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
