suneet-s commented on a change in pull request #11416:
URL: https://github.com/apache/druid/pull/11416#discussion_r667148670
##########
File path: web-console/script/create-sql-docs.js
##########
@@ -53,17 +57,17 @@ const readDoc = async () => {
}
}
- // Make sure there are at least 10 functions for sanity
- if (functionDocs.length < 10) {
+ // Make sure there are enough functions found
+ if (functionDocs.length < EXPECTED_NUMBER_OF_FUNCTIONS) {
Review comment:
Why not an equals check instead? Should the constant be renamed to
`MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
