loquisgon commented on a change in pull request #11419:
URL: https://github.com/apache/druid/pull/11419#discussion_r667171845
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -540,7 +540,9 @@ public boolean isWorkerRunningTask(ZkWorker worker, String
taskId)
} else if ((completeTask = completeTasks.get(task.getId())) != null) {
return completeTask.getResult();
} else {
- return addPendingTask(task).getResult();
+ RemoteTaskRunnerWorkItem workItem = addPendingTask(task);
+ runPendingTasks();
Review comment:
I find it confusing and error prone that after adding a task(s) now you
have to explicitly call run..., maybe ad a comment to make it clear that it is
required (else?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
