asdf2014 commented on a change in pull request #11427:
URL: https://github.com/apache/druid/pull/11427#discussion_r667346546
##########
File path: helm/druid/README.md
##########
@@ -25,20 +6,19 @@
To install the Druid Chart into your Kubernetes cluster :
-```bash
-helm install --namespace "druid" --name "druid" incubator/druid
-```
+1. `cd` to root directory of druid project
+2. execute command ```bash helm install --namespace "druid" --name "druid"
helm/druid```
Review comment:
```suggestion
2. execute command `helm install --namespace "druid" --name "druid"
helm/druid`
```
##########
File path: helm/druid/values.yaml
##########
@@ -26,32 +26,37 @@ configMap:
##
enabled: true
-## Define the key value pairs in the configmap
-configVars:
+## The configurations below would be set as environment variable across all pod
+globalConfig:
## DRUID env vars. ref:
https://github.com/apache/druid/blob/master/distribution/docker/druid.sh#L29
- # DRUID_LOG_LEVEL: "warn"
- # DRUID_LOG4J: <?xml version="1.0" encoding="UTF-8" ?><Configuration
status="WARN"><Appenders><Console name="Console"
target="SYSTEM_OUT"><PatternLayout pattern="%d{ISO8601} %p [%t] %c -
%m%n"/></Console></Appenders><Loggers><Root level="info"><AppenderRef
ref="Console"/></Root><Logger name="org.apache.druid.jetty.RequestLog"
additivity="false" level="DEBUG"><AppenderRef
ref="Console"/></Logger></Loggers></Configuration>
- DRUID_USE_CONTAINER_IP: "true"
+ DRUID_USE_CONTAINER_IP: 'true'
## Druid Common Configurations. ref:
https://druid.apache.org/docs/latest/configuration/index.html#common-configurations
- druid_extensions_loadList: '["druid-histogram", "druid-datasketches",
"druid-lookups-cached-global", "postgresql-metadata-storage"]'
- druid_metadata_storage_type: postgresql
- druid_metadata_storage_connector_connectURI:
jdbc:postgresql://postgres:5432/druid
- druid_metadata_storage_connector_user: druid
- druid_metadata_storage_connector_password: druid
+ druid_extensions_loadList: '["druid-datasketches",
"druid-lookups-cached-global", "postgresql-metadata-storage"]'
+
+ druid_metadata_storage_type: derby
+
druid_storage_type: local
+
druid_indexer_logs_type: file
- druid_indexer_logs_directory: /opt/data/indexing-logs
## Druid Emitting Metrics. ref:
https://druid.apache.org/docs/latest/configuration/index.html#emitting-metrics
druid_emitter: noop
- druid_emitter_logging_logLevel: debug
- druid_emitter_http_recipientBaseUrl:
http://druid_exporter_url:druid_exporter_port/druid
+ druid_emitter_logging_logLevel: info
gCloudStorage:
enabled: false
secretName: google-cloud-key
+hdfs:
+ # Enable hdfs as deep-storage reference:
http://druid.apache.org/docs/latest/development/extensions-core/hdfs.html
+ # Need to do:
+ # 1. enabled: true
+ # 2. add hdfs extension
Review comment:
```suggestion
# 2. add `"druid-hdfs-storage"` to `druid_extensions_loadList `
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
