maytasm edited a comment on pull request #11424: URL: https://github.com/apache/druid/pull/11424#issuecomment-877635280
@clintropolis @abhishekagarwal87 Sorry to bother you both but I had to make some changes to the PR. Turns out that I cannot simply bind TaskStorage in CliCoordinator. This is because when we run the Coordinator together with the Overlord, then both CliCoordinator and CliOverlord will both try to bind TaskStorage, resulting in Guice error. I have now added `beOverlord` condition check to only bind those if we the Coordinator is not also Overlord. Also added some other missing bindings and fix the IT so that when the auto cleanup runs there are both NoopSupervisorSpec and non-NoopSupervisorSpec (i.e. KafkaSupervisorSpec). Can you let me know when you review the PR again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
