suneet-s commented on a change in pull request #11440:
URL: https://github.com/apache/druid/pull/11440#discussion_r669040093
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/autoscaling/PendingTaskBasedWorkerProvisioningConfig.java
##########
@@ -29,6 +29,8 @@
@JsonProperty
private int maxScalingStep = 10;
+ @JsonProperty
+ private Integer workerCapacityFallback = null;
Review comment:
why did you choose to use an `Integer` object instead of an `int` with a
default value?
I suspect a Nullable Integer may be more error prone as callers may not
think to check for null and handle that case. At the very least, this field and
`getWorkerCapacityFallback` should be annotated with `Nullable` so static
analysis can catch places where users forget to add null checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
