jihoonson commented on pull request #11460: URL: https://github.com/apache/druid/pull/11460#issuecomment-882088185
Hi @dongjoon-hyun, thank you for the PR. The change LGTM, but the CI failure seems legit because [IOUtils.lineIterator no longer throws IOException in 2.11](https://github.com/apache/commons-io/blob/rel/commons-io-2.11.0/src/main/java/org/apache/commons/io/IOUtils.java#L1599). Can you please remove it from the `InlineFirehose` constructor? You would probably want to remove it from `InlineFirehoseFactory.connect` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
