abhishekagarwal87 opened a new pull request #11466: URL: https://github.com/apache/druid/pull/11466
This PR splits current `SegmentLoader` into `SegmentLoader` and `SegmentCacheManager`. - `SegmentLoader` - this class is responsible for building the segment object but does not expose any methods for downloading, cache space management, etc. Default implementation delegates the download operations to `SegmentCacheManager` and only contains the logic for building segments once downloaded. . This class will be used in `SegmentManager` to construct `Segment` objects. - `SegmentCacheManager` - this class manages the segment cache on the local disk. It fetches the segment files to the local disk, can clean up the cache, and in the future, support `reserve` and `release` on cache space. [See https://github.com/apache/druid/pull/11398]. This class will be used in ingestion tasks such as compaction, re-indexing where segment files need to be downloaded locally. <hr> ##### Key changed/added classes in this PR * `SegmentLoader` * `SegmentCacheManager` * `SegmentLoadDropHandler` * `SegmentLocalCacheManager` * `SegmentLocalCacheLoader` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
