suneet-s commented on a change in pull request #11489:
URL: https://github.com/apache/druid/pull/11489#discussion_r677456483



##########
File path: docs/operations/api-reference.md
##########
@@ -241,6 +243,8 @@ Note that all _interval_ URL parameters are ISO 8601 
strings delimited by a `_`
 
 Returns a list of datasource names found in the cluster.
 
+This method reads from the server view held by the coordinator that is updated 
every 
[`druid.coordinator.period`](../configuration/index.html#coordinator-operation),
 whereas `/druid/coordinator/v1/metadata/datasources` reads from metadata 
database.

Review comment:
       ```suggestion
   Returns a list of datasource names found in the cluster as seen by the 
coordinator. This view is updated every 
[`druid.coordinator.period`](../configuration/index.html#coordinator-operation).
   ```

##########
File path: docs/operations/api-reference.md
##########
@@ -189,6 +189,8 @@ Returns a list of all segments for one or more specific 
datasources with the ful
 
 Returns a list of the names of datasources with at least one used segment in 
the cluster.
 
+This method reads from the metadata database, whereas 
`/druid/coordinator/v1/datasources` reads from the cached server view held by 
the coordinator that is updated every 
[`druid.coordinator.period`](../configuration/index.html#coordinator-operation).

Review comment:
       nit: Instead of referring to another API in this description, we could 
talk about why someone would want to use this API. Similar comment below. What 
do you think?
   
   ```suggestion
   Returns a list of the names of datasources with at least one used segment in 
the cluster, retrieved from the metadata database. Users should call this API 
to get the eventual state that the system will be in.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to