jon-wei commented on a change in pull request #11501:
URL: https://github.com/apache/druid/pull/11501#discussion_r677903038
##########
File path:
server/src/main/java/org/apache/druid/client/indexing/HttpIndexingServiceClient.java
##########
@@ -70,7 +70,7 @@ public HttpIndexingServiceClient(
public void killUnusedSegments(String idPrefix, String dataSource, Interval
interval)
Review comment:
The two places where it's used currently:
```
@DELETE
@Path("/{dataSourceName}/intervals/{interval}")
```
on the coordinator which just issues a kill task
and internally by the coordinator in a coordinator duty which periodically
issues a kill task for segments that are unused (if that functionality is
enabled in the coordinator).
For the former case, it might make sense to add this parameter, but the same
API set already has the "markUnused" API, so I didn't feel it was necessary and
wanted to limit the scope of the PR, and for the latter case, the "markUnused"
flag doesn't make sense to enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
