zachjsh edited a comment on pull request #11507: URL: https://github.com/apache/druid/pull/11507#issuecomment-889322705
@pjain1 , Thank you for your contribution! This is awesome. Would you please add unit tests for DeepStorageIntermediaryDataManager, DeepStorageShuffleClient, DeepStoragePartitionLocation, and DeepStoragePartitionStat classes, and integration tests as well for this? We want to make sure that this feature does not break between releases. For the integration tests, you should be able to piggy back on the existing S3 deep storage integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
