maytasm opened a new pull request #11519:
URL: https://github.com/apache/druid/pull/11519
Improve query error logging
### Description
When adding and developing new query functionality (such as adding a new
Aggregator), it may be hard to debug due to limited logging information. This
PR change the log level of logging query exception (in QueryLifecycle) from
WARN to ERROR to make the Exception easier to find and identify. This PR also
adds a query context `logQueryExceptionStackTrace` that can make the above
error logging (in QueryLifecycle) to include the stack trace of the Exception.
This information will make it easier to identify bugs in the query
functionality that the user is using/developing.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]