rohangarg commented on pull request #11518: URL: https://github.com/apache/druid/pull/11518#issuecomment-890130354
@dongjoon-hyun : Yes, you are right. Apologies, I missed that dependency analysis in druid fails compilation if we're not declaring any directly used dependency (the default maven behavior gives a warning). Maybe that was the original reason to keep it explicit :) I had missed the `-DfailOnWarning=true` flag during local check so the compile had passed for me. Also, I did a quick lookup and the observation you had wrt to the transitive dependencies is correct - the maven page states that `Exclusions work on the entire dependency graph below the point where they are declared.` (https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html) You updated change LGTM - thanks for the tryout and changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
