jihoonson commented on pull request #11507: URL: https://github.com/apache/druid/pull/11507#issuecomment-892228999
> @jihoonson All the different classes with `*Generic*` in them were tied to `GenericPartitionLocation` but now I see we are ok in breaking that convention for few classes and they will work for `DeepStoragePartitionLocation` so thats fine, I can make that change. Thanks. BTW making PartitonLocation and PartitionStat an interface and other related changes was already done [here](https://github.com/apache/druid/pull/11507/commits/530db2ccb610bc1c4c1bb1cdaaba6edb520bbf37). Working on Task and config related changes. @pjain1 thanks! I will have a look. > @jihoonson I see in your branch you have made `PartialSegmentMergeIngestionSpec` a concrete class but also kept `PartialGenericSegmentMergeIngestionSpec`, is this for backwards compatibility reasons ? I think I just forgot to delete `PartialGenericSegmentMergeIngestionSpec`. It doesn't seem to have a compatibility issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
