abhishekagarwal87 commented on a change in pull request #11566:
URL: https://github.com/apache/druid/pull/11566#discussion_r687510192



##########
File path: docs/design/router.md
##########
@@ -137,6 +138,15 @@ Allows defining arbitrary routing rules using a JavaScript 
function. The functio
 
 > JavaScript-based functionality is disabled by default. Please refer to the 
 > Druid [JavaScript programming guide](../development/javascript.md) for 
 > guidelines about using Druid's JavaScript functionality, including 
 > instructions on how to enable it.
 
+### Routing of SQL queries

Review comment:
       do you want to add a note here about JDBC queries? 

##########
File path: 
services/src/main/java/org/apache/druid/server/router/TieredBrokerSelectorStrategy.java
##########
@@ -37,4 +38,9 @@
 public interface TieredBrokerSelectorStrategy
 {
   Optional<String> getBrokerServiceName(TieredBrokerConfig config, Query 
query);
+
+  default Optional<String> getBrokerServiceName(TieredBrokerConfig config, 
SqlQuery sqlQuery)

Review comment:
       Please add some javadocs here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to