FrankChen021 commented on a change in pull request #11456:
URL: https://github.com/apache/druid/pull/11456#discussion_r688887804



##########
File path: 
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordResource.java
##########
@@ -562,6 +563,7 @@ public Response getTasks(
       @QueryParam("datasource") final String dataSource,
       @QueryParam("createdTimeInterval") final String createdTimeInterval,
       @QueryParam("max") final Integer maxCompletedTasks,
+      @QueryParam("maxActiveTasks") final Integer maxActiveTasks,

Review comment:
       I think we don't need to add this new parameter because there's already 
a parameter named as 'max'.  The 'max' should limit not only completedTasks but 
also activeTasks. When parameter 'state' is not given, it limits the total 
number of tasks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to