oliverdding commented on pull request #11427: URL: https://github.com/apache/druid/pull/11427#issuecomment-898844738
> > > > > Thank you for your contribution @oliverdding. I had some questions and suggestions > > > > > > * what zk ensemble, the druid services will be initialized with after your changes? We would still need to pass `druid_zk_service_host` somehow? > > > * Instead of removing `mysql` and `postgres` entirely, I will suggest keeping them with `enabled` as `false` in default `values.yaml`. You can have two more `values.yaml` files inside `mysql` and `postgres` folder that a user can choose to override default `values.yaml` with. > > > > > > > > 1. Yes, you need to pass `druid_zk_service_host` if you want to use druid under zookeeper, but I consider that free from zookeeper is the future [run without zookeeper](http://druid.apache.org/docs/latest/development/extensions-core/kubernetes.html), so we should leave this blank in the base chart. > > 2. I did this considering that: > > > > * That's not K.I.S.S. User may want to deploy druid with mysql, may want to deploy without zookeeper... Though postgresql and zookeeper are our dependencies, we should not package them with our application. > > * User should deploy their own pod to fill in their own business. For example, my company has postgresql deployed as base componment, so I just want the druid to use that one instead of taking it's own without deployed. > > 1. Most of the deployments are still zk based so the helm chart should support that. > > 2. That can be achieved by tweaking the conditions. You can introduce new values such as `install.postgres`, `install.zookeeper`, and `install.mysql` that can be `false` by default. You can use these flags as conditions for deciding whether to download a dependency. > > 3. As suggested, please also add values.yaml that are specific to mysql and postgres that a user can pass in addition to the default values. The `values.yaml` inside `mysql` folder will look something like this > > > ``` > mysql: > enabled: true > mysqlRootPassword: druidroot > mysqlUser: druid > mysqlPassword: druid > mysqlDatabase: druid > configurationFiles: > mysql_collate.cnf: |- > [mysqld] > character-set-server=utf8 > collation-server=utf8_unicode_ci > ``` > > default root-directory `values.yaml` will have the following section > > ``` > mysql: > enabled: false > ``` > > same for postgres. The changes in configmap.yaml can be reverted. > > if a user wants to run with mysql enabled, he/she can run the helm install with values.yaml -f mysql/values.yaml Sorry for replaying late. I'm convinced. But I got a problem...I have deleted the forked repository when this MR is accepted... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
