techdocsmith commented on a change in pull request #11609:
URL: https://github.com/apache/druid/pull/11609#discussion_r690764846
##########
File path: docs/querying/sql.md
##########
@@ -336,6 +336,7 @@ Only the COUNT, ARRAY_AGG, and STRING_AGG aggregations can
accept the DISTINCT k
|`APPROX_COUNT_DISTINCT(expr)`|_Usage note:_ consider using
`APPROX_COUNT_DISTINCT_DS_HLL` instead, which offers better accuracy in many
cases.<br/><br/>Counts distinct values of expr, which can be a regular column
or a hyperUnique column. This is always approximate, regardless of the value of
"useApproximateCountDistinct". This uses Druid's built-in "cardinality" or
"hyperUnique" aggregators. See also `COUNT(DISTINCT expr)`.|`0`|
|`APPROX_COUNT_DISTINCT_DS_HLL(expr, [lgK, tgtHllType])`|Counts distinct
values of `expr`, which can be a regular column or an [HLL
sketch](../development/extensions-core/datasketches-hll.md) column. Results are
always approximate, regardless of the value of
[`useApproximateCountDistinct`](../querying/sql.html#connection-context). The
`lgK` and `tgtHllType` parameters here are, like the equivalents in the
[aggregator](../development/extensions-core/datasketches-hll.html#aggregators),
described in the HLL sketch documentation. The [DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
|`APPROX_COUNT_DISTINCT_DS_THETA(expr, [size])`|Counts distinct values of
expr, which can be a regular column or a [Theta
sketch](../development/extensions-core/datasketches-theta.md) column. This is
always approximate, regardless of the value of
[`useApproximateCountDistinct`](../querying/sql.html#connection-context). The
`size` parameter is described in the Theta sketch documentation. The
[DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
+|`APPROX_COUNT_DISTINCT_DS_THETA(expr, [size])`|Counts distinct values of
expr, which can be a regular column or a [Theta
sketch](../development/extensions-core/datasketches-theta.md) column. This is
always approximate, regardless of the value of
[`useApproximateCountDistinct`](#connection-context). The `size` parameter is
described in the Theta sketch documentation. The [DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
Review comment:
```suggestion
```
##########
File path: docs/querying/sql.md
##########
@@ -334,8 +334,8 @@ Only the COUNT, ARRAY_AGG, and STRING_AGG aggregations can
accept the DISTINCT k
|`MAX(expr)`|Takes the maximum of numbers.|`null` if
`druid.generic.useDefaultValueForNull=false`, otherwise `-9223372036854775808`
(minimum LONG value)|
|`AVG(expr)`|Averages numbers.|`null` if
`druid.generic.useDefaultValueForNull=false`, otherwise `0`|
|`APPROX_COUNT_DISTINCT(expr)`|_Usage note:_ consider using
`APPROX_COUNT_DISTINCT_DS_HLL` instead, which offers better accuracy in many
cases.<br/><br/>Counts distinct values of expr, which can be a regular column
or a hyperUnique column. This is always approximate, regardless of the value of
"useApproximateCountDistinct". This uses Druid's built-in "cardinality" or
"hyperUnique" aggregators. See also `COUNT(DISTINCT expr)`.|`0`|
-|`APPROX_COUNT_DISTINCT_DS_HLL(expr, [lgK, tgtHllType])`|Counts distinct
values of `expr`, which can be a regular column or an [HLL
sketch](../development/extensions-core/datasketches-hll.md) column. Results are
always approximate, regardless of the value of
[`useApproximateCountDistinct`](../querying/sql.html#connection-context). The
`lgK` and `tgtHllType` parameters here are, like the equivalents in the
[aggregator](../development/extensions-core/datasketches-hll.html#aggregators),
described in the HLL sketch documentation. The [DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
-|`APPROX_COUNT_DISTINCT_DS_THETA(expr, [size])`|Counts distinct values of
expr, which can be a regular column or a [Theta
sketch](../development/extensions-core/datasketches-theta.md) column. This is
always approximate, regardless of the value of
[`useApproximateCountDistinct`](../querying/sql.html#connection-context). The
`size` parameter is described in the Theta sketch documentation. The
[DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
+|`APPROX_COUNT_DISTINCT_DS_HLL(expr, [lgK, tgtHllType])`|Counts distinct
values of `expr`, which can be a regular column or an [HLL
sketch](../development/extensions-core/datasketches-hll.md) column. Results are
always approximate, regardless of the value of
[`useApproximateCountDistinct`](#connection-context). The `lgK` and
`tgtHllType` parameters here are, like the equivalents in the
[aggregator](../development/extensions-core/datasketches-hll.md#aggregators),
described in the HLL sketch documentation. The [DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
+|`APPROX_COUNT_DISTINCT_DS_THETA(expr, [size])`|Counts distinct values of
expr, which can be a regular column or a [Theta
sketch](../development/extensions-core/datasketches-theta.md) column. This is
always approximate, regardless of the value of
[`useApproximateCountDistinct`](#connection-context). The `size` parameter is
described in the Theta sketch documentation. The [DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
Review comment:
```suggestion
|`APPROX_COUNT_DISTINCT_DS_THETA(expr, [size])`|Counts distinct values of
expr, which can be a regular column or a [Theta
sketch](../development/extensions-core/datasketches-theta.md) column. This is
always approximate, regardless of the value of
[`useApproximateCountDistinct`](#connection-context). The `size` parameter is
described in the Theta sketch documentation. The [DataSketches
extension](../development/extensions-core/datasketches-extension.md) must be
loaded to use this function. See also `COUNT(DISTINCT expr)`. |`0`|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
