suneet-s commented on a change in pull request #11631:
URL: https://github.com/apache/druid/pull/11631#discussion_r696210133
##########
File path:
server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -116,8 +116,7 @@ public DataSchema(
if (this.granularitySpec.isRollup()) {
Review comment:
It seems like another option is to only warn if isRollup is true and
aggregators is empty. This way the current warning message would make more
sense.
```suggestion
if (this.granularitySpec.isRollup() && && this.aggregators.length == 0)
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
