jihoonson opened a new pull request #11643:
URL: https://github.com/apache/druid/pull/11643
### Description
This PR adds a cancellation API for SQLs mentioned in #4047. Similar to the
cancellation API for native queries, this new API first performs authorization
to see whether the requester has read permission for all resources of the
query. If it does, the API cancels _all_ sql queries of the given `sqlQueryId`.
When a query is canceled, its `SqlLifecycle` is marked as canceled
immediately. Once it's marked, any operation in `SqlLifecycle` becomes no-op so
that we can avoid executing expensive operations unnecessarily. Additionally, I
removed all locking in `SqlLifecycle` as it doesn't need to be thread-safe
except for canceling. For canceling, it uses a volatile variable and a
thread-safe data structure to avoid using locks in `SqlLifecycle`. This was
necessary for the cancel API to be able to interrupt while the query is
running, especially while executing `SqlLifecycle.execute()`.
The web console is currently simply closing the client connection when the
query is canceled and this behavior has not changed in this PR. As it seems
that the web console is doing the same even for native queries, we can fix them
all in a follow-up PR. Documentation will be in the follow-up PR as well.
<hr>
##### Key changed/added classes in this PR
* `SqlLifecycle`
* `SqlLifecycleManager`
* `SqlResource`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
