clintropolis opened a new pull request #11649: URL: https://github.com/apache/druid/pull/11649
### Description This PR fixes an issue I found by accident in `HashVectorGrouper`, which was incorrectly initializing a hashtable at the starting position of the memory rather than the `penultimate` ending position. This doesn't cause an issue, _except_ in the case where there is only enough room to grow a single time, because it results in overlapping memory regions for the tables when the max sized table tries to use the same position 0. Of the added test cases, only `testGrowOnce` fails prior to the fix in this PR. Im sure there is a more clever way to test this than explicit 'testGrowN` methods, but it was not immediately obvious to me so maybe a future improvement. This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
