suneet-s commented on pull request #11606: URL: https://github.com/apache/druid/pull/11606#issuecomment-916555363
Thanks for the contribution @nikhil-ddu ! Have you considered adding an integration test for these new parameters? I think `ITBasicAuthLdapConfigurationTest` is a potential place to add the test. The docker compose file to set up the cluster for ldap tests appears to be in `docker-compose.ldap-security.yml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
