techdocsmith commented on a change in pull request #11716:
URL: https://github.com/apache/druid/pull/11716#discussion_r714996429
##########
File path: docs/design/router.md
##########
@@ -138,18 +138,18 @@ Allows defining arbitrary routing rules using a
JavaScript function. The functio
> JavaScript-based functionality is disabled by default. Please refer to the
> Druid [JavaScript programming guide](../development/javascript.md) for
> guidelines about using Druid's JavaScript functionality, including
> instructions on how to enable it.
-### Routing of SQL queries
+### Routing of SQL queries using Strategies
Review comment:
```suggestion
### Routing of SQL queries using strategies
```
l/c : strategies is not a feature name.
##########
File path: docs/design/router.md
##########
@@ -138,18 +138,18 @@ Allows defining arbitrary routing rules using a
JavaScript function. The functio
> JavaScript-based functionality is disabled by default. Please refer to the
> Druid [JavaScript programming guide](../development/javascript.md) for
> guidelines about using Druid's JavaScript functionality, including
> instructions on how to enable it.
-### Routing of SQL queries
+### Routing of SQL queries using Strategies
-To enable routing of SQL queries, set `druid.router.sql.enable` to `true`
(`false` by default). The broker service for a
+To enable routing of SQL queries using strategies, set
`druid.router.sql.enable` to `true`. The broker service for a
given SQL query is resolved using only the provided Router strategies. If not
resolved using any of the strategies, the
Router uses the `defaultBrokerServiceName`. This behavior is slightly
different from native queries where the Router
first tries to resolve the broker service using strategies, then load rules
and finally using the `defaultBrokerServiceName`
-if still not resolved.
+if still not resolved. When `druid.router.sql.enable` is set to `false`
(default value), the Router uses the
+`defaultBrokerServiceName`.
-Routing of native queries is always enabled.
-
-Setting `druid.router.sql.enable` does not affect Avatica JDBC requests. They
are routed based on connection ID as
-explained in the next section.
+Setting `druid.router.sql.enable` does not affect either Avatica JDBC requests
or Native Queries.
+Native queries are always routed using strategies and load rules as explained
above.
Review comment:
```suggestion
Druid always routes native queries using the strategies and load rules as
documented.
```
better to avoid positional reference
##########
File path: docs/design/router.md
##########
@@ -138,18 +138,18 @@ Allows defining arbitrary routing rules using a
JavaScript function. The functio
> JavaScript-based functionality is disabled by default. Please refer to the
> Druid [JavaScript programming guide](../development/javascript.md) for
> guidelines about using Druid's JavaScript functionality, including
> instructions on how to enable it.
-### Routing of SQL queries
+### Routing of SQL queries using Strategies
-To enable routing of SQL queries, set `druid.router.sql.enable` to `true`
(`false` by default). The broker service for a
+To enable routing of SQL queries using strategies, set
`druid.router.sql.enable` to `true`. The broker service for a
given SQL query is resolved using only the provided Router strategies. If not
resolved using any of the strategies, the
Router uses the `defaultBrokerServiceName`. This behavior is slightly
different from native queries where the Router
first tries to resolve the broker service using strategies, then load rules
and finally using the `defaultBrokerServiceName`
-if still not resolved.
+if still not resolved. When `druid.router.sql.enable` is set to `false`
(default value), the Router uses the
+`defaultBrokerServiceName`.
-Routing of native queries is always enabled.
-
-Setting `druid.router.sql.enable` does not affect Avatica JDBC requests. They
are routed based on connection ID as
-explained in the next section.
+Setting `druid.router.sql.enable` does not affect either Avatica JDBC requests
or Native Queries.
Review comment:
```suggestion
Setting `druid.router.sql.enable` does not affect either Avatica JDBC
requests or native queries.
```
##########
File path: docs/configuration/index.md
##########
@@ -2054,7 +2054,7 @@ Supported query contexts:
|`druid.router.tierToBrokerMap`|Queries for a certain tier of data are routed
to their appropriate Broker. This value should be an ordered JSON map of tiers
to Broker names. The priority of Brokers is based on the
ordering.|{"_default_tier": "<defaultBrokerServiceName>"}|
|`druid.router.defaultRule`|The default rule for all datasources.|"_default"|
|`druid.router.pollPeriod`|How often to poll for new rules.|PT1M|
-|`druid.router.sql.enable`|Enable routing of SQL queries. Possible values are
`true` and `false`. When set to `true`, the Router uses the provided strategies
to determine the broker service for a given SQL query.|`false`|
+|`druid.router.sql.enable`|Enable routing of SQL queries using strategies.
Possible values are `true` and `false`. When set to `true`, the Router uses the
provided strategies to determine the broker service for a given SQL query. When
set to `false`, the Router uses the `defaultBrokerServiceName`.|`false`|
Review comment:
```suggestion
|`druid.router.sql.enable`|Enable routing of SQL queries using strategies.
When`true`, the Router uses the strategies defined in
`druid.router.strategies` to determine the broker service for a given SQL
query. When `false`, the Router uses the `defaultBrokerServiceName`.|`false`|
```
No need to enumerate "true/false" for boolean. It's assumed. Suggest
clarifying where to configure strategies (`druid.router.strategies`).
##########
File path: docs/design/router.md
##########
@@ -138,18 +138,18 @@ Allows defining arbitrary routing rules using a
JavaScript function. The functio
> JavaScript-based functionality is disabled by default. Please refer to the
> Druid [JavaScript programming guide](../development/javascript.md) for
> guidelines about using Druid's JavaScript functionality, including
> instructions on how to enable it.
-### Routing of SQL queries
+### Routing of SQL queries using Strategies
-To enable routing of SQL queries, set `druid.router.sql.enable` to `true`
(`false` by default). The broker service for a
+To enable routing of SQL queries using strategies, set
`druid.router.sql.enable` to `true`. The broker service for a
given SQL query is resolved using only the provided Router strategies. If not
resolved using any of the strategies, the
Router uses the `defaultBrokerServiceName`. This behavior is slightly
different from native queries where the Router
first tries to resolve the broker service using strategies, then load rules
and finally using the `defaultBrokerServiceName`
-if still not resolved.
+if still not resolved. When `druid.router.sql.enable` is set to `false`
(default value), the Router uses the
+`defaultBrokerServiceName`.
-Routing of native queries is always enabled.
-
-Setting `druid.router.sql.enable` does not affect Avatica JDBC requests. They
are routed based on connection ID as
-explained in the next section.
+Setting `druid.router.sql.enable` does not affect either Avatica JDBC requests
or Native Queries.
+Native queries are always routed using strategies and load rules as explained
above.
+Avatica JDBC requests are always routed based on connection ID as explained in
the next section.
Review comment:
```suggestion
Druid always routes Avatica JDBC requests based on connection ID.
```
Think it's OK not to mention "the next section" since it follows immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
