techdocsmith commented on a change in pull request #11761:
URL: https://github.com/apache/druid/pull/11761#discussion_r719793929
##########
File path: docs/querying/sql.md
##########
@@ -871,13 +871,13 @@ Submit your query as the value of a "query" field in the
JSON object within the
{"query" : "SELECT COUNT(*) FROM data_source WHERE foo = 'bar'"}
```
-##### Request
+##### Request body
|Property|Description|Default|
|--------|----|-----------|
|`query`|SQL query string.| none (required)|
|`resultFormat`|Format of query results. See [Responses](#responses) for
details.|`"object"`|
-|`header`|Whether or not to include a header. See [Responses] for
details.|`false`|
+|`header`|Whether or not to include a header. See [Responses](#responses) for
details.|`false`|
Review comment:
Maybe clarify further that this means header row for the result set, not
having to do with the HTTP header.
##########
File path: docs/querying/sql.md
##########
@@ -952,6 +952,8 @@ You can additionally request a header by setting "header"
to true in your reques
In this case, the first result returned will be a header. For the `csv`,
`array`, and `arrayLines` formats, the header
will be a list of column names. For the `object` and `objectLines` formats,
the header will be an object where the
keys are column names, and the values are null.
+If you specified `sqlQueryId` in the [connection context
parameters](#connection-context),
+the SQL query identifier will be returned in the header labeled
`X-Druid-SQL-Query-Id`.
Review comment:
```suggestion
Druid returns the SQL query identifier in the `X-Druid-SQL-Query-Id` header.
```
nit: prefer active
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
