clintropolis commented on pull request #11713: URL: https://github.com/apache/druid/pull/11713#issuecomment-932487604
I've taken some measurements to check to see if there is any performance regression from the changes in this PR, and it looks ok to me. I chose expressions to measure since non-vectorized expression processing is the most intensive use of type stuff since things are checked every row, the majority of other uses of type information is per segment or per query. before: ``` Benchmark (query) (rowsPerSegment) (vectorize) Mode Cnt Score Error Units SqlExpressionBenchmark.querySql 4 5000000 false avgt 5 266.083 ± 15.995 ms/op SqlExpressionBenchmark.querySql 4 5000000 force avgt 5 107.886 ± 7.874 ms/op SqlExpressionBenchmark.querySql 10 5000000 false avgt 5 1112.108 ± 91.164 ms/op SqlExpressionBenchmark.querySql 10 5000000 force avgt 5 200.173 ± 20.951 ms/op SqlExpressionBenchmark.querySql 17 5000000 false avgt 5 592.618 ± 58.979 ms/op SqlExpressionBenchmark.querySql 17 5000000 force avgt 5 139.361 ± 15.943 ms/op SqlExpressionBenchmark.querySql 24 5000000 false avgt 5 1628.440 ± 553.147 ms/op SqlExpressionBenchmark.querySql 24 5000000 force avgt 5 748.706 ± 168.330 ms/op SqlExpressionBenchmark.querySql 25 5000000 false avgt 5 462.776 ± 38.855 ms/op SqlExpressionBenchmark.querySql 25 5000000 force avgt 5 105.150 ± 10.052 ms/op SqlExpressionBenchmark.querySql 28 5000000 false avgt 5 655.110 ± 99.443 ms/op SqlExpressionBenchmark.querySql 28 5000000 force avgt 5 148.242 ± 11.095 ms/op SqlExpressionBenchmark.querySql 29 5000000 false avgt 5 759.389 ± 52.080 ms/op SqlExpressionBenchmark.querySql 29 5000000 force avgt 5 164.460 ± 19.277 ms/op ``` after: ``` Benchmark (query) (rowsPerSegment) (vectorize) Mode Cnt Score Error Units SqlExpressionBenchmark.querySql 4 5000000 false avgt 5 265.765 ± 19.279 ms/op SqlExpressionBenchmark.querySql 4 5000000 force avgt 5 105.661 ± 7.709 ms/op SqlExpressionBenchmark.querySql 10 5000000 false avgt 5 1234.551 ± 88.114 ms/op SqlExpressionBenchmark.querySql 10 5000000 force avgt 5 195.991 ± 10.841 ms/op SqlExpressionBenchmark.querySql 17 5000000 false avgt 5 583.678 ± 45.943 ms/op SqlExpressionBenchmark.querySql 17 5000000 force avgt 5 140.554 ± 14.233 ms/op SqlExpressionBenchmark.querySql 24 5000000 false avgt 5 1576.548 ± 179.227 ms/op SqlExpressionBenchmark.querySql 24 5000000 force avgt 5 733.372 ± 110.739 ms/op SqlExpressionBenchmark.querySql 25 5000000 false avgt 5 489.465 ± 15.953 ms/op SqlExpressionBenchmark.querySql 25 5000000 force avgt 5 107.505 ± 1.933 ms/op SqlExpressionBenchmark.querySql 28 5000000 false avgt 5 731.998 ± 64.078 ms/op SqlExpressionBenchmark.querySql 28 5000000 force avgt 5 149.572 ± 11.913 ms/op SqlExpressionBenchmark.querySql 29 5000000 false avgt 5 801.768 ± 23.847 ms/op SqlExpressionBenchmark.querySql 29 5000000 force avgt 5 163.067 ± 9.628 ms/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
