techdocsmith commented on a change in pull request #11767:
URL: https://github.com/apache/druid/pull/11767#discussion_r721511719
##########
File path: docs/development/extensions-core/kinesis-ingestion.md
##########
@@ -141,8 +141,8 @@ Where the file `supervisor-spec.json` contains a Kinesis
supervisor spec:
|`completionTimeout`|ISO8601 Period|The length of time to wait before
declaring a publishing task as failed and terminating it. If this is set too
low, your tasks may never publish. The publishing clock for a task begins
roughly after `taskDuration` elapses.|no (default == PT6H)|
|`lateMessageRejectionPeriod`|ISO8601 Period|Configure tasks to reject
messages with timestamps earlier than this period before the task was created;
for example if this is set to `PT1H` and the supervisor creates a task at
*2016-01-01T12:00Z*, messages with timestamps earlier than *2016-01-01T11:00Z*
will be dropped. This may help prevent concurrency issues if your data stream
has late messages and you have multiple pipelines that need to operate on the
same segments (e.g. a realtime and a nightly batch ingestion pipeline).|no
(default == none)|
|`earlyMessageRejectionPeriod`|ISO8601 Period|Configure tasks to reject
messages with timestamps later than this period after the task reached its
taskDuration; for example if this is set to `PT1H`, the taskDuration is set to
`PT1H` and the supervisor creates a task at *2016-01-01T12:00Z*, messages with
timestamps later than *2016-01-01T14:00Z* will be dropped. **Note:** Tasks
sometimes run past their task duration, for example, in cases of supervisor
failover. Setting earlyMessageRejectionPeriod too low may cause messages to be
dropped unexpectedly whenever a task runs past its originally configured task
duration.|no (default == none)|
-|`recordsPerFetch`|Integer|The number of records to request per GetRecords
call to Kinesis. See 'Determining Fetch Settings' below.|no (default == 2000)|
-|`fetchDelayMillis`|Integer|Time in milliseconds to wait between subsequent
GetRecords calls to Kinesis. See 'Determining Fetch Settings' below.|no
(default == 1000)|
+|`recordsPerFetch`|Integer|The number of records to request per GetRecords
call to Kinesis. See 'Determining Fetch Settings' below.|no (default == 4000)|
+|`fetchDelayMillis`|Integer|Time in milliseconds to wait between subsequent
GetRecords calls to Kinesis. See 'Determining Fetch Settings' below.|no
(default == 0)|
Review comment:
```suggestion
|`recordsPerFetch`|Integer|The number of records to request per call to
fetch records from Kinesis. See [Determining fetch
settings](#determining-fetch-settings).|no (default == 4000)|
|`fetchDelayMillis`|Integer|Time in milliseconds to wait between subsequent
calls to fetch records from Kinesis. See [Determining fetch
settings](#determining-fetch-settings).|no (default == 0)|
```
suggest link instead of "below"; suggest using Engilsh instead of code
`GetRecords`. (I realize that was existing). If you keep it, it should be in
code `GetRecords`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
