lokesh-lingarajan commented on a change in pull request #11630:
URL: https://github.com/apache/druid/pull/11630#discussion_r721601068



##########
File path: docs/development/extensions-core/kafka-ingestion.md
##########
@@ -240,11 +240,10 @@ Supported `inputFormat`s include:
 - `csv`
 - `delimited`
 - `json`
+- `kafka`
 - `avro_stream`
 - `protobuf`
 
-For more information, see [Data formats](../../ingestion/data-formats.md). You 
can also read [`thrift`](../extensions-contrib/thrift.md) formats using 
`parser`.

Review comment:
       thats a fat finger issue, will undo it.

##########
File path: docs/ingestion/data-formats.md
##########
@@ -151,6 +151,57 @@ Be sure to change the `delimiter` to the appropriate 
delimiter for your data. Li
 }
 ```
 
+### KAFKA
+
+The `inputFormat` to load complete kafka record including header, key and 
value. An example is:
+
+```json
+"ioConfig": {
+  "inputFormat": {
+      "type": "kafka",
+      "headerLabelPrefix": "kafka.header.",
+      "timestampColumnName": "kafka.timestamp",
+      "keyColumnName": "kafka.key",
+      "headerFormat":
+      {
+        "type": "string"
+      },
+      "keyFormat":
+      {
+        "type": "json"
+      },
+      "valueFormat":
+      {
+        "type": "json"
+      }
+  },
+  ...
+}
+```
+
+The KAFKA `inputFormat` has the following components:
+
+| Field | Type | Description | Required |
+|-------|------|-------------|----------|
+| type | String | This should say `kafka`. | yes |
+| headerLabelPrefix | String | A custom label prefix for all the header 
columns. | no (default = "kafka.header.") |
+| timestampColumnName | String | Specifies the name of the column for the 
kafka record's timestamp.| no (default = "kafka.timestamp") |
+| keyColumnName | String | Specifies the name of the column for the kafka 
record's key.| no (default = "kafka.key") |
+| headerFormat | Object | headerFormat specifies how to parse the kafka 
headers. Current supported type is "string". | no |

Review comment:
       Sure will add some notes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to