jihoonson opened a new pull request #11770:
URL: https://github.com/apache/druid/pull/11770


   ### Description
   
   Druid currently has 2 serverViews, regular serverView and filtered 
serverView. The regular serverView is used to monitor all segment announcements 
from all data nodes (historicals, tasks, indexers). The filtered serverView is 
used when you want to watch segment announcements from particular tiers. Since 
these server views keep track of different sets of druidServers and segments in 
memory, they should be maintained separately. However, they currently share the 
same name for their executorService, which can cause confusion and make 
debugging harder especially in the broker since it is using both serverViews, 
the filtered view for normal query processing and the regular view to serve the 
`servers` table (I'm unsure whether this is intended or whether this is a good 
behavior). This PR changes it to a more obvious name. 
   
   This PR also removes `SingleServerInventoryView`. This view was deprecated a 
long time ago and has not been documented at least since 0.13 
(https://github.com/apache/druid/pull/6127). I also don't think this can be 
better in any case than `BatchServerInventoryView`. Finally, I merged 
`AbstractCuratorServerInventoryView` and `BatchServerInventoryView` as we no 
longer need `AbstractCuratorServerInventoryView` after 
`SingleServerInventoryView` is removed.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * 
`BatchServerInventoryViewProvider`/`FilteredBatchServerInventoryViewProvider`
    * 
`HttpServerInventoryViewProvider`/`FilteredHttpServerInventoryViewProvider`
    * `BatchServerInventoryView`
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to