adilev26 commented on a change in pull request #11807:
URL: https://github.com/apache/druid/pull/11807#discussion_r731743547
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSupervisorManager.java
##########
@@ -185,6 +169,60 @@ public Void withHandle(Handle handle) throws Exception
);
}
+ @Override
+ public List<VersionedSupervisorSpec> getAllForId(String id)
+ {
+ return ImmutableList.copyOf(
+ dbi.withHandle(
+ new HandleCallback<List<VersionedSupervisorSpec>>()
+ {
+ @Override
+ public List<VersionedSupervisorSpec> withHandle(Handle handle)
+ {
+ return handle.createQuery(
+ StringUtils.format(
+ "SELECT id, spec_id, created_date, payload FROM %1$s
WHERE spec_id = :spec_id ORDER BY id DESC",
Review comment:
better to get the select fields from the same place, now we have 2
places, get all and get specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
