arunramani commented on pull request #11810: URL: https://github.com/apache/druid/pull/11810#issuecomment-947846864
> Changes LGTM but the approach itself was not clear till I did a deep dive into the test case. it might be nice to add an example at the code level E.g. let's say that the proc mount path for `cpu,cpuacct` is `/sys/fs/cgroup/cpu,cpuacct` and the cgroup path for `cpu,cputacct` is `/system.slice/some.service/f12ba7e0-fa16-462e-bb9d-652ccc27f0ee`, then the first path we look for is > > `/sys/fs/cgroup/cpu,cpuacct/system.slice/some.service/f12ba7e0-fa16-462e-bb9d-652ccc27f0ee` In case, above is not a valid directory, the fallback path is `/sys/fs/cgroup/cpu,cpuacct` Agreed, I added a detailed doc comment with an example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
