sthetland commented on a change in pull request #11826:
URL: https://github.com/apache/druid/pull/11826#discussion_r734015689
##########
File path: docs/querying/sql.md
##########
@@ -476,8 +476,8 @@ simplest way to write literal timestamps in other time
zones is to use TIME_PARS
|`CURRENT_TIMESTAMP`|Current timestamp in the connection's time zone.|
|`CURRENT_DATE`|Current date in the connection's time zone.|
|`DATE_TRUNC(<unit>, <timestamp_expr>)`|Rounds down a timestamp, returning it
as a new timestamp. Unit can be 'milliseconds', 'second', 'minute', 'hour',
'day', 'week', 'month', 'quarter', 'year', 'decade', 'century', or
'millennium'.|
-|`TIME_CEIL(<timestamp_expr>, <period>, [<origin>, [<timezone>]])`|Rounds up a
timestamp, returning it as a new timestamp. Period can be any ISO8601 period,
like P3M (quarters) or PT12H (half-days). The time zone, if provided, should be
a time zone name like "America/Los_Angeles" or offset like "-08:00". This
function is similar to `CEIL` but is more flexible.|
-|`TIME_FLOOR(<timestamp_expr>, <period>, [<origin>, [<timezone>]])`|Rounds
down a timestamp, returning it as a new timestamp. Period can be any ISO8601
period, like P3M (quarters) or PT12H (half-days). The time zone, if provided,
should be a time zone name like "America/Los_Angeles" or offset like "-08:00".
This function is similar to `FLOOR` but is more flexible.|
+|`TIME_CEIL(<timestamp_expr>, <period>, [<origin>, [<timezone>]])`|Rounds up a
timestamp, returning it as a new timestamp. Period can be any ISO8601 period,
like P3M (quarters) or PT12H (half-days). The time zone, if provided, should be
a time zone name like "America/Los_Angeles" or offset like "-08:00". Specify
`<origin>` as a timestamp to set the reference time for rounding. For example,
an hourly period, `PT1H`, can be measured from 00:30-01:30 instead of
00:00-01:00. See [Period granularities](granularities.md) for details on the
default starting boundaries. This function is similar to `CEIL` but is more
flexible.|
Review comment:
Looks good. Only suggestion would be to put the parameter descriptions
in the order they appear in the format.. so move the preceding time zone
sentence to be after the new text. Could also add that the time zone also sets
the reference time for rounding, which is otherwise set to UTC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
