gianm commented on a change in pull request #11739:
URL: https://github.com/apache/druid/pull/11739#discussion_r734241414



##########
File path: core/src/main/java/org/apache/druid/indexer/TaskLocation.java
##########
@@ -75,6 +78,19 @@ public int getTlsPort()
     return tlsPort;
   }
 
+  public URL makeURL(final String encodedPathAndQueryString) throws 
MalformedURLException

Review comment:
       There doesn't seem to be much consistency here, like you said 🤠
   
   I went with URL since there are so many other URLs in the same line 
(java.net.URL, MalformedURLException) so it seemed reasonable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to