clintropolis commented on a change in pull request #11818:
URL: https://github.com/apache/druid/pull/11818#discussion_r734784053
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/FieldAccessPostAggregator.java
##########
@@ -89,9 +91,16 @@ public String getName()
}
@Override
- public ColumnType getType()
+ public ColumnType getType(ColumnInspector signature)
{
- return type;
+ if (type != null) {
+ return type;
+ }
+ final ColumnCapabilities capabilities =
signature.getColumnCapabilities(fieldName);
Review comment:
`RowSignature` already has a `getColumnType` though it returns an
optional instead of nullable, so we would have to match it (or i guess give
another name).
Also, I still have a dream that someday `ExpressionType` and `ColumnType`
will be the same so then `getType` would serve that purpose, but not quite
there yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
