JulianJaffePinterest edited a comment on pull request #11823: URL: https://github.com/apache/druid/pull/11823#issuecomment-953674869
@jihoonson thanks for starting your review. The end-to-end tests I was referring to in our earlier discussion haven't been added yet (since this PR doesn't include the writing logic), but when they are added no changes will be necessary - they're lightweight enough run as part of `mvn test`. This PR does include the unit tests for the reader logic, which also run via `mvn test`, as expected. If you'd like, I can create an explicit Travis job for the spark tests instead of letting them be bundled into the `other modules test` jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
