jon-wei commented on a change in pull request #11863:
URL: https://github.com/apache/druid/pull/11863#discussion_r740468584
##########
File path: docs/development/extensions-core/lookups-cached-global.md
##########
@@ -204,7 +204,8 @@ The remapping values for each globally cached lookup can be
specified by a JSON
"\"value\"]"
]
},
- "pollPeriod":"PT5M"
+ "pollPeriod":"PT5M",
+ "maxSize": 5242880
Review comment:
I think it'd make more sense to express this as a percentage of
available heap instead of a fixed byte limit, since the amount of available
memory can differ across the various nodes where lookups might be loaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
