gianm opened a new pull request #11886: URL: https://github.com/apache/druid/pull/11886
The main reason this is good is that Sequences can include baggage that must be closed after iteration is finished. This enables creating RowBasedSegments on top of closeable sequences of rows. To preserve the optimization that allows reversing a List without copying it, this patch also makes SimpleSequence its own class and allows extracting the Iterable that was used to create it. Nothing actually uses this capability yet, but in future work I'd like to explore building RowBasedSegments on top of more kinds of things, some of which may need to have resource cleanup associated with them. So this patch enables that without bothering existing usages too much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
