kfaraz commented on a change in pull request #11899:
URL: https://github.com/apache/druid/pull/11899#discussion_r746505107
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentPuller.java
##########
@@ -231,6 +229,8 @@ public Writer openWriter()
@Override
public long getLastModified()
{
+ final S3ObjectSummary objectSummary =
Review comment:
Making the LIST call here every time `getLastModified` is called seems
costly.
Maybe initialize it lazily but only once the way `s3Object` is being
initialized in `openInputStream`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
