cheddar commented on a change in pull request #11902:
URL: https://github.com/apache/druid/pull/11902#discussion_r747168899
##########
File path: core/src/main/java/org/apache/druid/timeline/partition/ShardSpec.java
##########
@@ -123,6 +123,12 @@ default short getAtomicUpdateGroupSize()
@JsonIgnore
boolean possibleInDomain(Map<String, RangeSet<String>> domain);
+ /**
+ * Get the type name of this ShardSpec.
+ */
+ @JsonIgnore
+ String getType();
Review comment:
This should have a default implementation that returns something like
"unknown". I don't know if anybody has implemented this interface in an
extension, but it's technically possible and no reason to break their stuff if
they did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
