LakshSingla opened a new pull request #11908:
URL: https://github.com/apache/druid/pull/11908


   ### Description
   
   Currently, when we try to do `EXPLAIN PLAN FOR`, it returns the structure of 
the SQL parsed (via Calcite's internal planner util), which is verbose (since 
it tries to explain about the nodes in the SQL, instead of the Druid Query), 
and not representative of the native Druid query which will get executed on the 
broker side.
   For example: 
   // Example here
   
   This PR aims to change the format when user tries to `EXPLAIN PLAN FOR` for 
queries which are executed by converting them into Druid's native queries (i.e. 
not `sys` schemas).
   
   The explanation now will be a list of columns with information about 
`resources` (no change) and `explanation`. 
   Explanation is a string representing an array of queries & their signatures 
(in JSON format). Final shape of the `explanation` will look like:
   
   ```
   [
     { 
       "query" : <native_druid_query>,
       "signature": <signature of the query>
     },
     {
       "query" : <native_druid_query>,
       "signature": <signature of the query>
     }
   ]
   ```
   
   
   <!-- Describe the goal of this PR, what problem are you fixing. If there is 
a corresponding issue (referenced above), it's not necessary to repeat the 
description here, however, you may choose to keep one summary sentence. -->
   
   <!-- Describe your patch: what did you change in code? How did you fix the 
problem? -->
   
   <!-- If there are several relatively logically separate changes in this PR, 
create a mini-section for each of them. For example: -->
   
   
   
   <!-- It's good to describe an alternative design (or mention an alternative 
name) for every design (or naming) decision point and compare the alternatives 
with the designs that you've implemented (or the names you've chosen) to 
highlight the advantages of the chosen designs and names. -->
   
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small 
changes. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * Modified implementation of `DruidPlanner#planExplanation`. 
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to