LakshSingla opened a new pull request #11923:
URL: https://github.com/apache/druid/pull/11923
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is
a corresponding issue (referenced above), it's not necessary to repeat the
description here, however, you may choose to keep one summary sentence. -->
Bug: `SELECT floor(123)` returns `1230`
(In comparison,
`SELECT 123` returns `123`,
`SELECT floor(123) from druid.foo` returns `123`
)
Cause: `DruidLogicalValuesRule` while transforming to `DruidRel` can return
incorrect values, if during the creation of the literal it was created from a
float value.
<!-- Describe your patch: what did you change in code? How did you fix the
problem? -->
Extract the values of INT/LONG from the RexLiteral in the
`DruidLogicalValuesRule`, via `BigDecimal.longValue()` method.
<!-- If there are several relatively logically separate changes in this PR,
create a mini-section for each of them. For example: -->
<hr>
##### Key changed/added classes in this PR
* Minor update in `DruidLogicalValuesRule#getValueFromLiteral`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
