isandeep41 opened a new pull request #11945:
URL: https://github.com/apache/druid/pull/11945


   Key updates:
   - Dependency needs to be updated before chart installation
   - Fixes namespace name, `[may not contain '/']`
   - helm delete is now helm uninstall, [see][1]
   - `--purge` flag has been deprecated [see][1]
   - > Instead of using the --purge flag on helm uninstall the behavior is to 
use the --keep-history if you want to keep the history.
   - removes unnecessary lock file
   
   Tested on: 
   ```sh
   $ helm version
   version.BuildInfo{Version:"v3.7.0", 
GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", 
GoVersion:"go1.17"}
   ```
   
   [1]: https://helm.sh/blog/helm-v3-beta/#notable-changes-since-helm-v2
   
   ### Description
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to